Use DatabaseKey for interned events#813
Merged
MichaReiser merged 2 commits intosalsa-rs:masterfrom Apr 24, 2025
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #813 will improve performances by 6.79%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
I very much question the performance improvements 😆 |
MichaReiser
force-pushed
the
interned-events-key
branch
from
f6bff96 to
6aafb95
Compare
Veykril
approved these changes
Apr 24, 2025
MichaReiser
force-pushed
the
interned-events-key
branch
from
6aafb95 to
cae027a
Compare
Member
|
The dynamically dispatched event call is likely affecting inlining in a variety of ways (sometimes good sometimes bad), certainly contributes to the noise at times |
MichaReiser
force-pushed
the
interned-events-key
branch
from
cae027a to
10f5832
Compare
This was referenced Apr 24, 2025
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to other events, use
DatabaseKeyfor interned events.This has the advantage that logging the event reveals the id and the struct name
Test plan
See updated snapshot tests